feat: Complete Pi coding agent integration#233
Closed
hjanuschka wants to merge 3 commits intoentireio:mainfrom
Closed
feat: Complete Pi coding agent integration#233hjanuschka wants to merge 3 commits intoentireio:mainfrom
hjanuschka wants to merge 3 commits intoentireio:mainfrom
Conversation
Implements full Pi coding agent support with: - Complete Agent interface implementation - JSONL transcript parsing matching Pi's session format - Modified files extraction from write/edit tool calls - TranscriptAnalyzer interface for efficient position tracking - TranscriptChunker interface for large transcript handling - HookSupport for extension-based hook installation - HookHandler with session-start, session-end, stop, user-prompt-submit hooks - Proper session directory detection (~/.pi/agent/sessions/) - Extension package installation via .pi/settings.json The implementation follows the same patterns as claudecode and geminicli agents, with full support for: - Hook input parsing from stdin JSON - Session reading/writing with NativeData preservation - File modification tracking from tool results - Transcript position tracking for incremental updates Works with the companion npm package @anthropic/pi-entire which provides the pi extension that calls these hooks. Closes entireio#221
- GetLastUserPrompt() - Extract last user prompt from session - TruncateAtUUID() - Truncate session at entry ID for rewind - FindCheckpointUUID() - Find entry ID for tool call (checkpoint lookup) - CalculateTokenUsage() - Basic token usage tracking Also fix package name to @hjanuschka/pi-entire
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 6 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Fixes all 6 issues identified in PR entireio#233 code review: High Severity: - Pi agent registration: Added side-effect imports to hooks_cmd.go and config.go to ensure Pi agent init() runs and registers with the agent registry. Without this, 'entire hooks pi' commands were non-functional. - Settings round-trip preservation: Refactored InstallHooks, UninstallHooks, and AreHooksInstalled to use map[string]json.RawMessage pattern (matching Claude agent) to preserve unknown JSON fields in .pi/settings.json instead of unmarshaling into PiSettings struct that only has Packages/Extensions. Medium Severity: - Incremental file extraction: Added assistant message handling to ExtractModifiedFilesFromOffset to match extractModifiedFiles behavior. Now extracts file paths from both toolResult messages AND assistant messages with toolCall content blocks (write/edit). Low Severity: - Line counting consistency: Fixed off-by-one in GetTranscriptPosition to count last line even when it lacks trailing newline, matching ExtractModifiedFilesFromOffset behavior. - Dead code removal: Removed unreachable .pi/settings.json check in DetectPresence (can't exist if .pi directory doesn't exist). - Constant deduplication: Removed local AgentNamePi/AgentTypePi constants, now using agent.AgentNamePi/AgentTypePi from registry like Claude/Gemini agents do. Closes cursor-bot review feedback on PR entireio#233.
Author
|
ready for review! |
squishykid
added
enhancement
Member
|
@hjanuschka we are working on an improved agent interface, once that's merged we will be able to add Pi coding! |
Author
|
awesome good to know
Von meinem iPhone gesendet
Am 16.02.2026 um 16:47 schrieb Robin Wohlers-Reichel ***@***.***>:
squishykid left a comment (entireio/cli#233) <#233 (comment)>
@hjanuschka we are working on an improved agent interface, once that's merged we will be able to add Pi coding!
#281
—
Reply to this email directly, view it on GitHub <#233 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWB7NWCWX2PMY6576TMKJD4MHRC3AVCNFSM6AAAAACUVZVQZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMBZGE4TEMJUGI> .
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AAWB7NQEUVEJVMEVTZVKRDT4MHRC3A5CNFSM6AAAAACUVZVQZKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTXJAGE44.gif> Message ID: ***@***.***>
|
khaong
added
on-hold
|
Is this ready to be merged now that #281 has been finished or does it require a refactor? |
Contributor
|
👋 @hjanuschka thank you for your contribution! We shifted pattern and introduced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete implementation of Pi coding agent support for Entire CLI. This supersedes the skeleton in #232 with a fully functional implementation.
What's included
Agent Implementation (
cmd/entire/cli/agent/pi/)pi.go - Full Agent interface implementation:
DetectPresence()- Checks for.pidirectoryParseHookInput()- Parses JSON from pi extension hooksReadSession()/WriteSession()- JSONL transcript handlingGetSessionDir()- Returns~/.pi/agent/sessions/<sanitized-path>/extractModifiedFiles()- Parses write/edit tool calls from transcriptsTranscriptAnalyzerinterface - Efficient position trackingTranscriptChunkerinterface - Large transcript handlinghooks.go - HookSupport and HookHandler:
InstallHooks()- Addsnpm:@hjanuschka/pi-entireto.pi/settings.jsonUninstallHooks()- Removes the extension packageGetHookNames()- Returnssession-start,session-end,stop,user-prompt-submittypes.go - Pi-specific data structures:
piHookInput- JSON input from extensionpiSessionEntry- JSONL session line formatpiMessage/piContentBlock- Message content typesRegistry Updates
AgentNamePiandAgentTypePiconstantsHow it works
Pi uses an extension-based architecture rather than external hook scripts. The integration consists of:
entire hooks pi <hook>commandsWhen
entire enable --agent piis run:.pi/settings.jsonis updated with"packages": ["npm:@hjanuschka/pi-entire"]entire hooks pi session-start, etc. with JSON on stdinTesting
Related
Companion package
The npm package
@hjanuschka/pi-entireprovides the pi extension side of this integration:https://github.com/hjanuschka/pi-entire
Note
Medium Risk
Adds a new agent integration that reads/writes local files and parses untrusted JSONL transcripts/settings, so bugs could affect hook installation or session processing but core existing agents are largely untouched.
Overview
Adds Pi coding agent support to Entire CLI via a new
piagent implementation.This introduces Pi-specific hook handling by installing/uninstalling the
npm:@hjanuschka/pi-entireextension in.pi/settings.json, parsing hook JSON from stdin, and adding Pi session transcript support (JSONL read/write, truncation/checkpoint lookup, modified-file extraction, and transcript position/chunking helpers). The agent registry is updated to includeAgentNamePi/AgentTypePiconstants.Written by Cursor Bugbot for commit b787315. This will update automatically on new commits. Configure here.